-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Prepare for renaming master -> main #13235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DHowett We don't have to keep the master branch after this, becuase GitHub automatically redirects to the renamed branch |
|
That makes sense. Thanks! I'll update this to the latest and we can get it merged sooner rather than later. |
…ermain # Conflicts: # SUPPORT.md
| <controls:SettingsPageControl.SecondaryLinks> | ||
| <controls:PageLink x:Uid="GeneralPage_PrivacyStatement_URL" Link="http://go.microsoft.com/fwlink/?LinkId=521839"/> | ||
| <controls:PageLink x:Uid="OpenSource_Notice" Link="https://github.com/microsoft/PowerToys/blob/master/NOTICE.md"/> | ||
| <controls:PageLink x:Uid="OpenSource_Notice" Link="https://github.com/microsoft/PowerToys/blob/main/NOTICE.md"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crutkas: we need to file a followup to fix this.
To my understanding, the open source notices need to be bundled with the product and accessible offline. They must be present in all binary distributions of the product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminal handles this by converting the markdown notice to HTML and bundling it in the package. The open-source version contains only a link to the repository, but the final release build contains the actual notices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do bundle so it is on disk with the installer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This pull request replaces all references to PowerToys' master branch
with "main" in documentation, code and build rules.
the issue.
(not applicable)