[Settings] Restore window size and position #13912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @davidegiacometti , as you've mentioned, I think catching exceptions on JSON reading/parsing in order to revert to default might be good. |
jaimecbernardo
suggested changes
Oct 22, 2021
Contributor
jaimecbernardo
left a comment
jaimecbernardo
left a comment
There was a problem hiding this comment.
Nice work! 😄
I think a couple of changes are still needed.
Some better error handling, reverting to default, as mentioned in the description.
If the previous window position is partially out of a monitor it still displays the Windows cut. It should revert to default when the Windows is partially offscreen, I think.
davidegiacometti
force-pushed
the
users/davidegiacometti/issue-3685
branch
from
c6a8d53 to
af2527d
Compare
davidegiacometti
force-pushed
the
users/davidegiacometti/issue-3685
branch
from
af2527d to
2ab9c3f
Compare
jaimecbernardo
approved these changes
Oct 25, 2021
Contributor
jaimecbernardo
left a comment
jaimecbernardo
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for the contribution!
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Restore settings window size and position
What is include in the PR:
Let's discuss about this solution. Should I add try-catch to be more safe?
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.