Put UpdateResultsListViewAfterQuery calls inside addResultLock blocks #14078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
requested review from
SeraphimaZykova,
jaimecbernardo and
yuyoyuppe
stefansjfw
changed the title
yuyoyuppe
approved these changes
Oct 29, 2021
SeraphimaZykova
approved these changes
Nov 1, 2021
Contributor
SeraphimaZykova
left a comment
SeraphimaZykova
left a comment
There was a problem hiding this comment.
Cannot repro the crash, but changes look reasonable.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Stack trace shows that PT Run crashed in
UpdateResultsListViewAfterQueryfunction, lineResults.Results.NotifyChanges(). For some reason array is being copied (at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)`) there...My assumption is that this crash happens because
Results.Resultscan be changed in parallel both fromParallel.ForEach(plugins, (plugin) =>block while executing delayed plugins (e.g.Results.Results.RemoveAll(r => r.Result.PluginID == plugin.Metadata.ID);line) andUpdateResultsListViewAfterQuerywhich is invoked after processing non-delayed plugins (System.Array.Copymentioned above).What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.