Skip to content

Conversation

@stefansjfw
Copy link
Contributor

Summary of the Pull Request

What is this about:
Including Runtime libs in PowerRename install folder.

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: [Power Rename] not opening anymore #14076
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

Hit fix PR?

@franky920920
Copy link
Contributor

Hit fix PR?

IMO, this won't be the main reason for a hotfix. But there is a hotfix (maybe 0.49.2?). We should introduce this one.

@stefansjfw
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaimecbernardo
Copy link
Contributor

Have you tested the resulting installer on a clean VM?

Copy link
Contributor

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefansjfw
Copy link
Contributor Author

Have you tested the resulting installer on a clean VM?

Yes

@stefansjfw stefansjfw merged commit 3dc8559 into main Nov 2, 2021
@stefansjfw stefansjfw deleted the stefan/installer_add_powerrename_runtime_dep branch November 2, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants