[PT Run] If only delayed results available, select first #14209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
requested review from
SeraphimaZykova,
jaimecbernardo and
yuyoyuppe
franky920920
approved these changes
Nov 2, 2021
Contributor
franky920920
left a comment
franky920920
left a comment
There was a problem hiding this comment.
LGTM! Tested and work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
So far, if query results were produced only by delayed executed plugins (Search plugin is the only delayed plugin atm), none of the results were auto-selected. With this change, in this case, first result in the list is selected.
Tested with custom build and confirmed by the user that reported the issue. Check the discussion there.
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.