Skip to content

Conversation

@stefansjfw
Copy link
Contributor

Summary of the Pull Request

What is this about:

What is included in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@stefansjfw stefansjfw force-pushed the stefan/remove_powerrenameuwpui branch from 3adcbf8 to a12794a Compare January 4, 2022 11:41
@stefansjfw stefansjfw changed the title [PowerRename] Renmove PowerRenameUWPUI project [PowerRename] Remove PowerRenameUWPUI project Jan 4, 2022
@microsoft microsoft deleted a comment from github-actions bot Jan 4, 2022
Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This project was created to make PowerRename work in MSIX context at the time it used Win32 UI.

@crutkas
Copy link
Member

crutkas commented Jan 11, 2022

any reason to not merge this?

@stefansjfw stefansjfw force-pushed the stefan/remove_powerrenameuwpui branch from 155c26d to b42d7fb Compare January 12, 2022 09:29
@stefansjfw stefansjfw merged commit aa87683 into main Jan 12, 2022
@stefansjfw stefansjfw deleted the stefan/remove_powerrenameuwpui branch January 12, 2022 10:03
@stefansjfw
Copy link
Contributor Author

any reason to not merge this?

not anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants