[FancyZones] Split zones-settings: layout hotkeys #15514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
stefansjfw
approved these changes
Jan 14, 2022
Contributor
stefansjfw
left a comment
stefansjfw
left a comment
There was a problem hiding this comment.
added few minor comments, but overall looks good and works good!
src/modules/fancyzones/FancyZonesLib/FancyZonesData/LayoutHotkeys.cpp
Outdated
Show resolved
Hide resolved
src/modules/fancyzones/FancyZonesLib/FancyZonesWinHookEventIDs.h
Outdated
Show resolved
Hide resolved
|
|
||
| void FancyZonesData::ReplaceZoneSettingsFileFromOlderVersions() | ||
| { | ||
| if (std::filesystem::exists(zonesSettingsFileName)) |
Contributor
There was a problem hiding this comment.
once it's migrated, no need to do it every time? add && if NOT exist hotkeysFile to condition?
Contributor
Author
There was a problem hiding this comment.
I'm planning to add the code removing the zones-settings.json after I finish with other parts. So checking only this one will be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
I decided to split the fix into separate issues for each part of the
zones-settings. This is the first part with layout hotkeys.FancyZonesDataWhat is included in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.