[FancyZones] Split zones-settings: custom layouts #15642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Jan 19, 2022
| <ClInclude Include="ZonesOverlay.h" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClCompile Include="FancyZonesData\CustomLayouts.cpp"> |
Contributor
There was a problem hiding this comment.
this looks a bit weird. Does it have to be this way?
Contributor
Author
There was a problem hiding this comment.
Otherwise, we'll have a pipeline build fail. See #15624
Member
|
what is the background for the issue + fix? |
Contributor
Author
Users lose data on driver updates or windows crashes. It happens because FZ tries to rewrite |
gregjacobson
added a commit
to gregjacobson/windows-uwp
that referenced
this pull request
May 21, 2022
The `zones-settings.json` file was removed and split into different files in microsoft/PowerToys#15642. However, the current documentation still references the removed `zones-settings.json` file. This update fixes the file location and also mentions the other newly available configuration files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
custom-layouts.jsonfrom zones-settings on FZ startcustom-layout.jsonin Editor.What is included in the PR:
How does someone test / validate:
custom-layouts.jsoncreatedQuality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.