-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove XP (and Server 2003) support from STL #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually probably need to keep not only |
I'll only remove functions in anonymous namespace, others cannot be safely removed. |
# Conflicts: # stl/src/awint.hpp # stl/src/filesystem.cpp # stl/src/winapinls.cpp # stl/src/winapisupp.cpp
# Conflicts: # stl/src/taskscheduler.cpp
Consolidate stl_MEOW_concrt comments.
Previously needed for __crtInitOnceExecuteOnce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for working on this extensive set of changes! I'll push fixes for ABI compat and a few other things.
Awesome - your PR shrinks the STL's main DLL by 1%! This is an extremely rare gift, thank you! 🎉 Changelog for the commits I pushed:
|
I believe I've successfully ported your |
Thanks again for this wonderful improvement - ripping out unnecessary complicated code is so awesome. 😸 |
Resolves #1192