_Execute_once bug fix. #1356
Merged
_Execute_once bug fix. #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrabet I believe you should link your account to the Microsoft organization instead of signing the CLA which is for contributors outside Microsoft. |
CaseyCarter
approved these changes
Oct 8, 2020
cbezault
approved these changes
Oct 8, 2020
StephanTLavavej
approved these changes
Oct 8, 2020
|
Thanks for investigating and fixing this bug so quickly! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original XFG enlightening for _Execute_once tried to be clever by using Context to pass the final callback to the trampoline. Unfortunately, Context is used by InitOnceExecuteOnce itself and having the wrong bits set can result in an error being returned. This PR addresses this by defining a struct which contains the parameter value and callback pointer to pass those to the trampoline.