Update TypeScript DOM Libs #47445
Update TypeScript DOM Libs #47445
Conversation
typescript-bot
added
Domain: lib.d.ts
typescript-bot
force-pushed
the
update-dom
branch
from
3649604 to
903cb75
Compare
|
@typescript-bot test this |
|
This looks like it won't break much, IMO |
|
@typescript-bot run dt |
| prototype: AbortSignal; | ||
| new(): AbortSignal; | ||
| // abort(): AbortSignal; - To be re-added in the future | ||
| abort(reason?: any): AbortSignal; |
There was a problem hiding this comment.
This I thought was a part of the automation, but I guess not - might have to change it on the DOM side
There was a problem hiding this comment.
You mean we might need to add an override?
There was a problem hiding this comment.
Nah, this was not supposed to happen because it conflicts with the node AbortSignal - but the deploy process didn't take into account the new param - microsoft/TypeScript-DOM-lib-generator@1bba426
| readonly CONNECTING: number; | ||
| readonly OPEN: number; | ||
| addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void; | ||
| addEventListener(type: string, listener: (this: EventSource, event: MessageEvent) => any, options?: boolean | AddEventListenerOptions): void; |
There was a problem hiding this comment.
What's the rationale for these new overloads?
There was a problem hiding this comment.
microsoft/TypeScript-DOM-lib-generator#736 with microsoft/TypeScript-DOM-lib-generator#1182 - basically default to message event if we don't know the event name
|
Going to merge this for now for the beta, but I still feel a little confused about those 2 changes. |
3 participants
This PR was generated by @orta from https://github.com/microsoft/TypeScript-DOM-lib-generator/