mergeSymbol in checker:Remove block-scoped duplicate declaration errors in plain JS #47825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were issued in mergeSymbol, not they are not issued.
typescript-bot
added
Author: Team
For Uncommitted Bug
sandersn
changed the title
Comment on lines
+1341
to
+1342
| if (!isSourcePlainJs) addDuplicateLocations(conflictingSymbolInfo.firstFileLocations, source); | ||
| if (!isTargetPlainJs) addDuplicateLocations(conflictingSymbolInfo.secondFileLocations, target); |
There was a problem hiding this comment.
Definitely weird - if you get one in one file, it's helpful to know where the other is. But you can always find-all-references I suppose.
There was a problem hiding this comment.
I'm trying to imitate the existing post-compile filtration of JS errors, which behaves the same way. It's definitely not ideal.
Edit: Actually, this maintains the pre-4.6 behaviour if you have a global const in a TS file and a global const in a JS file. The latter will not report the error, the former will.
DanielRosenwasser
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were issued in mergeSymbol, now they are not issued.