Skip to content

Support for node v23 #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for node v23 #880

wants to merge 1 commit into from

Conversation

nairmanu
Copy link
Collaborator

@nairmanu nairmanu commented Jun 27, 2025

This pull request updates the handling of package.json imports in Rollup configuration files, fixes a plugin array issue in clarity-js, and removes an unused import in clarity-js source code.

Replaced the assert { type: 'json' } syntax for importing package.json with fs.readFileSync and JSON.parse in rollup.config.ts. This ensures compatibility with newer NodeJS versions that dropped support for assert syntax.

@nairmanu nairmanu requested a review from Copilot June 27, 2025 16:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates configuration files to support Node v23 by replacing the JSON module import with a file read approach and removes an unused import.

  • Replace package.json import with a readFileSync-based JSON parse.
  • Remove unused import in the clarity-js layout style file.
  • Fix a stray comma in the plugins array of clarity-js' rollup config.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/clarity-visualize/rollup.config.ts Replaces JSON module import with readFileSync for package.json.
packages/clarity-js/src/layout/style.ts Removes unused "Metric" import from clarity-types/data.
packages/clarity-js/rollup.config.ts Updates package.json import and fixes a stray comma in plugins.
packages/clarity-decode/rollup.config.ts Replaces JSON module import with readFileSync for package.json.
Comments suppressed due to low confidence (2)

packages/clarity-js/src/layout/style.ts:1

  • Verify that removal of the 'Metric' import is intentional and that no remaining code references it.
import { Event } from "@clarity-types/data";

packages/clarity-js/rollup.config.ts:33

  • The stray comma in the plugins array has been corrected; please confirm that the updated syntax fully aligns with the project's configuration standards.
    plugins: [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants