Add CMake build and a limited subset of tests for llvm-mingw #1216
Conversation
|
So getting mingw to work with msbuild like we do for Clang is not practical? |
| # alternative to midl that can produce winmd files. Also, even if we do manage | ||
| # to reuse the MSVC-compiled binaries, mingw-w64 is still missing | ||
| # windowsnumerics.impl.h which is needed to provide the types |
There was a problem hiding this comment.
The Clang builds depend on the Windows SDK, just like MSVC. I take it mingw doesn't?
There was a problem hiding this comment.
They have their own equivalent headers due to the Windows SDK license not allowing redistribution, and the SDK headers depending on too many MSVC-isms
There was a problem hiding this comment.
It's also important to distinguish key aspect here: Clang can target both MSVC ABI (using Windows SDK) and GCC ABI (using mingw-w64).
|
For clang, msbuild supports it through clang-cl. In GCC/mingw's case, there is no such tool, and VS doesn't have native support |
|
Yeah, most has been said already. Another point is that mingw-w64 is commonly used as a way to cross-compile applications for Windows from another Unix-like OS, so headers and tools from MSVC or the Windows SDK usually does not work even if we ignore the licensing issues. (I will also have to look into this aspect later -- I'm not sure how we can use the cppwinrt tool and/or its generated headers for cross-compilation.) |
alvinhochun
force-pushed
the
alvin/llvm-mingw-cmake2
branch
from
884b2ad to
a6876cd
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
alvinhochun
force-pushed
the
alvin/llvm-mingw-cmake2
branch
from
a6876cd to
132239c
Compare
alvinhochun
changed the title
|
I would like this to be merged so we can at least have some CI coverage for llvm-mingw. I can continue to add more tests later. |
mingw-support/xmllite.def
Outdated
| @@ -0,0 +1,13 @@ | |||
| ; | |||
There was a problem hiding this comment.
These are very simple def files. I'm not sure what value it provides to have them generated by a tool and what licensing issues may occur as a result. Can we remove the comments?
There was a problem hiding this comment.
Also, if it'd be possible to update to a newer snapshot of mingw-w64 (unfortunately I don't have an actual release of my toolchains that includes it) this wouldn't be needed iirc.
Other than that, removing the comment should surely be fine.
This add a CMake build for building cppwinrt and a limited subset of the existing tests using the llvm-mingw toolchain. A GHA CI build using this toolchain is also included.
More tests will be added later.
Depends on #1212 and #1215
CC @mstorsjo