Skip to content

Move build pipeline into YAML #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 1, 2023
Merged

Move build pipeline into YAML #1268

merged 10 commits into from
Feb 1, 2023

Conversation

DefaultRyan
Copy link
Member

Among other things, this will allow the C++/WinRT build pipeline to stay synchronized with the product code.

build.yaml contains the same build steps as the original classic pipeline. Here's a test run. https://microsoft.visualstudio.com/Dart/_build/results?buildId=63658741&view=results

kennykerr
kennykerr previously approved these changes Jan 31, 2023
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@kennykerr
Copy link
Collaborator

image

Weird that it seems to be "failing" because of a prior run:

image

Might just be some weird sync between GitHub and Azure.

@kennykerr kennykerr self-requested a review January 31, 2023 17:50
@kennykerr kennykerr dismissed their stale review January 31, 2023 17:50

See David's feedback

@DefaultRyan DefaultRyan requested a review from dmachaj January 31, 2023 19:46
dmachaj
dmachaj previously approved these changes Jan 31, 2023
@DefaultRyan
Copy link
Member Author

The microsoft.cppwinrt build is hitting some weird NuGet timeout issues. Not related to this change.

@DefaultRyan DefaultRyan merged commit d68a8c7 into master Feb 1, 2023
@DefaultRyan DefaultRyan deleted the user/defaultryan/yaml branch February 1, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants