Skip to content

Workaround for false positive code analysis warning #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2023
Merged

Workaround for false positive code analysis warning #1269

merged 3 commits into from
Feb 6, 2023

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Feb 3, 2023 •
edited
Loading

The issue is that the code analysis engine doesn't realize - it doesn't look at the implementation - that the pointer stored within the com_ptr is actually checked for validity before proceeding.

Fixes #1267

@kennykerr kennykerr requested a review from oldnewthing February 3, 2023 16:49
Scottj1s
Scottj1s approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping back in!

@kennykerr kennykerr merged commit 3bbee2c into master Feb 6, 2023
@kennykerr kennykerr deleted the ca-workaround branch February 6, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scottj1s Scottj1s Scottj1s approved these changes

@oldnewthing oldnewthing Awaiting requested review from oldnewthing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implements class template triggers false positive code analysis warning
2 participants
@kennykerr @Scottj1s