Remove explicitly setting PreferredToolArchitecture, since VS 2022 handles this more comprehensively #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndles this more comprehensively
dmachaj
reviewed
May 15, 2023
| @@ -13,7 +13,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup> | |||
| <PreferredToolArchitecture>x64</PreferredToolArchitecture> | |||
There was a problem hiding this comment.
Should this be scoped to the VS2022 build tools (so that VS2019 still gets it set)?
There was a problem hiding this comment.
Or the opposite; only set it for VS2019 and then VS2022+ do not set it because VS does the right thing already.
There was a problem hiding this comment.
I don't think the latest version of cppwinrt supports the 2019 compiler any longer.
There was a problem hiding this comment.
It's actually a bug to set it in VS2019 when building for ARM64 (reported elsewhere). And since it's just a build optimization, I think better to remove it altogether, than to effectively copy the intelligence in the VS 2022 Microsoft.Cpp.ToolsetLocation.props.
kennykerr
approved these changes
May 15, 2023
dmachaj
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1302
With VS 2022, PreferredToolArchitecture is now set appropriately for every architecture (via Microsoft.Cpp.ToolsetLocation.props), so should no longer be set unconditionally by C++/WinRT