Spelling #1412
Spelling #1412
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
I was wondering when this PR would arrive. 😂 |
There was a problem hiding this comment.
I think this comes from somewhere as I'm pretty sure I've changed it elsewhere in the past. Happy to drop this or anything else.
There was a problem hiding this comment.
Yes, I can update catch.hpp to the latest version. https://github.com/catchorg/Catch2
| @@ -11310,7 +11310,7 @@ namespace Catch { | |||
| std::string TagInfo::all() const { | |||
| size_t size = 0; | |||
| for (auto const& spelling : spellings) { | |||
| // Add 2 for the brackes | |||
| // Add 2 for the brackets | |||
There was a problem hiding this comment.
Things like this are frustrating -- it could be braces and it isn't terribly obvious, but I'm moderately confident because later in the file it does compose [ + ... + ].
|
Hey, I'm recovering from a concussion 🤕, so I've been taking it easy... |
|
I should note that it jumped the queue, I have >400 repositories to go. |
|
Am I missing the spelling.yml in this PR? Sorry to hear about the concussion. Hope you get some rest. |
|
spelling.yml isn't included, if you're interested, I'm happy to make a PR with it :). -- I'll have to make some adjustments as I develop these PRs using the bleeding edge version (it's how I test changes), but I generally contribute the latest supported version (although I do hope to ship a new version soonish -- as, sadly, the latest release has dependencies on some of those node16 components...). |
|
Got it - no rush on the workflow but that would be neat. Thanks again. |
Fixes misspellings identified by the check-spelling action.
The misspellings will be reported at https://github.com/jsoref/cppwinrt/actions/runs/8574313379
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/cppwinrt/actions/runs/8574313511
(Sorry, I'm heading out and these are running behind a CI task that's validating things, but I'm fairly confident in the changes...)