Skip to content

Add missing <exception> to base_includes.h #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add missing <exception> to base_includes.h #1427

merged 1 commit into from
Jul 31, 2024

Conversation

m417z
Copy link
Contributor

@m417z m417z commented Jul 26, 2024

Clang with std=c++23 rightfully complains that std::exception_ptr isn't defined.

kennykerr
kennykerr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennykerr kennykerr merged commit 0deecf1 into microsoft:master Jul 31, 2024
75 checks passed
@m417z m417z deleted the patch-1 branch July 31, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m417z @kennykerr