Skip to content

Suppress warning on exit by properly closing pydevd socket #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Suppress warning on exit by properly closing pydevd socket #1826

merged 2 commits into from
Feb 5, 2025

Conversation

bersbersbers
Copy link
Contributor

Closes #1812.

I am unsure if I should submit this to https://github.com/fabioz/PyDev.Debugger (first) because I can reproduce this only in conjunction with debugpy, like so:

C:\Git\debugpy\src>python -m debugpy --listen 5000 -c "import warnings; warnings.filterwarnings('error')"

@bersbersbers bersbersbers requested a review from a team as a code owner February 5, 2025 13:16
@rchiodo
Copy link
Contributor

rchiodo commented Feb 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rchiodo
Copy link
Contributor

rchiodo commented Feb 5, 2025

I am unsure if I should submit this to https://github.com/fabioz/PyDev.Debugger (first) because I can reproduce this only in conjunction with debugpy

That's kinda strange, but we do try to keep pydev.debugger and debugpy in sync. So theoretically a push here will end up in Pydev.debugger eventually.

@bersbersbers
Copy link
Contributor Author

It's less strange once you consider that I started looking into pydevd only to fix this one bug. I have no idea how to even connect anything to pydevd, apart from debugpy. So I should probably rephrase, I don't know how I can reproduce it in pydevd, but that should not mean that I believe there is no way at all.

@rchiodo rchiodo merged commit fb0b06c into microsoft:main Feb 5, 2025
21 of 24 checks passed
@rchiodo
Copy link
Contributor

rchiodo commented Feb 5, 2025

Thanks for the submission. Should ship in our next release.

@bersbersbers
Copy link
Contributor Author

Backport in fabioz/PyDev.Debugger#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceWarning: unclosed socket
2 participants