Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Support TypeScript 2.8 in the header language version parser #12

Merged
2 commits merged into from
Apr 20, 2018

Conversation

fbartho
Copy link

@fbartho fbartho commented Apr 3, 2018

  1. I wanted to update a project I use type-zoo to use TypeScript language features introduced in TypeScript 2.8.
  2. This project depends on dtslint for validating TypeScript Versions
  3. Selecting // TypeScript Version 2.8 causes dtslint to fail, which forced me to figure out how dtslint finds language versions, which pointed me to this repo.
  • This also fixes a warning in the npm install output.
  • This also updates the package-lock.json file as TypeScript has a new next version now.

@msftclas
Copy link

msftclas commented Apr 3, 2018

CLA assistant check
All CLA requirements met.

@fbartho
Copy link
Author

fbartho commented Apr 3, 2018

/cc @Andy-MS -- since you commented on the last version patch :P

@fbartho
Copy link
Author

fbartho commented Apr 11, 2018

@pelotom
Copy link

pelotom commented Apr 20, 2018

Hi, could someone from the TypeScript team look at this? 2.8 has been out for almost a month now and nobody can test typings that rely on conditional types with dtslint because of this.

@ghost ghost merged commit 0437222 into microsoft:production Apr 20, 2018
@pelotom
Copy link

pelotom commented Apr 20, 2018

Thanks, @Andy-MS!

@fbartho fbartho deleted the production branch April 20, 2018 17:46
@fbartho
Copy link
Author

fbartho commented Apr 20, 2018

Thanks @Andy-MS!

Not to ask more of you, but it looks like you also contribute to dtslint! Would you mind updating the package-lock.json to include this version of definitelytyped-header-parser & deploy a new version of that as well? -- It would fix this issue: microsoft/dtslint#113 and unblock this issue: pelotom/type-zoo#14

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants