Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Activate application from .winget files #2379

Merged
merged 12 commits into from
Mar 25, 2024

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Mar 8, 2024

Summary of the pull request

  • ℹ️ All credits go to @joadoumie 🙌 Work was primarly on-hold when the DSC was being moved to out-of-proc.
  • New activation handler added: DSCFileActivationHandler was added to handle:
    • Activating Dev Home from a .winget file when the app is not running
    • Activating Dev Home from a .winget file when the app is already running
  • In both cases, triggering the DSC activation handler should not:
    • Interrupt the user if the setup flow is already in progress
    • Crash if the feature is not enabled

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

File with *.winget can activate the DSC flow in Dev Home:

image

Show message when the DSC configuration feature is disabled

image

Show message when the user already started the machine configuration flow

image

PR checklist

@AmelBawa-msft AmelBawa-msft mentioned this pull request Mar 8, 2024
1 task
else
{
NavigationService.NavigateTo(typeof(WhatsNewViewModel).FullName!);
case ExtendedActivationKind.File:
Copy link
Contributor Author

@AmelBawa-msft AmelBawa-msft Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue to consider moving this methods logic to an activation handler instead

@joadoumie
Copy link
Contributor

@RDMacLachlan -- for visibility.

This PR is finally ready to be merged shortly.

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review March 8, 2024 23:45
try
{
// Don't interrupt the user if the machine configuration is in progress
if (_setupFlowOrchestrator.FlowPages.Count > 1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add telemetry (issue)

@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Mar 15, 2024
@AmelBawa-msft AmelBawa-msft merged commit 23acc63 into main Mar 25, 2024
@AmelBawa-msft AmelBawa-msft deleted the user/joadoumie/file-activation branch March 25, 2024 19:50
@ethanfangg
Copy link

let's go @joadoumie that's my teammate!

@krschau krschau removed the Needs-Second Pull request that needs another approval label Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to open a YAML file directly into the machine configuration yaml flow
6 participants