Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Fix additional scroll regions #2445

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Fix additional scroll regions #2445

merged 4 commits into from
Mar 25, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Mar 20, 2024

Summary of the pull request

Fix a couple things missed in #2423:

  • Fix scroll regions for ExtensionSettingsPage
  • Fix margins in SetupFlow's SetupShell and Environments's LandingPage so that the header and content isn't taking up the whole MaxWidth

And

  • Removed a temporary debugging border that accidentally got left in

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau added the Needs-Second Pull request that needs another approval label Mar 21, 2024
Copy link
Contributor

@adrastogi adrastogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau merged commit e93c8fe into main Mar 25, 2024
@krschau krschau deleted the user/krschau/scroll-regions2 branch March 25, 2024 16:29
@krschau krschau removed the Needs-Second Pull request that needs another approval label Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Home Scroll Regions are the wrong size
4 participants