This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fixing bug where user could not invoke selectable menu flyout action with Narrator's scan mode on #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
AmelBawa-msft,
krschau,
dkbennett,
dhoehna and
EricJohnson327
dhoehna
approved these changes
Apr 9, 2024
krschau
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
When the Narrator's scan mode is on, the user cannot use the keyboard to select the widget's size. This PR fix the issue.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49658657
Detailed description of the pull request / Additional comments
When the Narrator's scan mode is on, the Automation Peer's
Selectmethod from theSelectionItempattern gets the priority on the keyboard action, going over theInvokefrom the invoke pattern. This PR makes theSelectto callInvokewhenever it is called, as the behaviour should always be the same.Validation steps performed
PR checklist