This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Changing Width to MinWidth to fix clipping button content in Extensions page #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
krschau,
AmelBawa-msft,
dhoehna,
dkbennett,
vineeththomasalex and
EricJohnson327
krschau
approved these changes
Apr 12, 2024
vineeththomasalex
approved these changes
Apr 12, 2024
dhoehna
reviewed
Apr 12, 2024
| @@ -74,7 +74,7 @@ | |||
| <!-- This StackPanel is a workaround for the bug https://github.com/CommunityToolkit/Windows/issues/396 --> | |||
| <Button x:Uid="MoreOptionsButton" | |||
| Content="" | |||
| Height="36" Width="36" | |||
| Height="36" MinWidth="36" | |||
There was a problem hiding this comment.
is Setting minWidth the correct solution? Would getting rid of Width be better? Allow the content to expand and shrink dynamically? With MinWidth, the content won't shrink past a certain point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Before
After
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49656778
Detailed description of the pull request / Additional comments
Changed Width to MinWidth so the button's content don't get clipped when there is lack of space.
Validation steps performed
PR checklist