This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Defining contrast color #2788
Merged
Defining contrast color #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
manodasanW,
jsidewhite,
nieubank,
guimafelipe,
huzaifa-d,
vineeththomasalex,
dkbennett,
jaholme,
krschau,
EricJohnson327,
sshilov7,
brialmsft,
hart-wilson,
SohamDas2021,
AmelBawa-msft,
bbonaby,
srupakula,
ssparach and
a team
nieubank
approved these changes
Apr 30, 2024
krschau
approved these changes
May 1, 2024
vineeththomasalex
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
DevHome crashes on the "What's new" page when viewing on a high-contrast theme because
LearnMoreForegroundis not defined for HighContrast.Fixed by defining
LearnMoreForegroundto theHighContrastResourceDictionaryAlso removed the unused
ButtonAccentkeys.References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist
Picture!
