Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Improving the narrator with DevHome #2986

Merged
merged 5 commits into from
May 23, 2024

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented May 22, 2024

Summary of the pull request

In some places, the narrator was not saying the correct thing in 3 specific cases

  1. The ... on an environment card. Narrator now says "More Options"
  2. The expander in the review page. Narrator now says the title of the expander.
  3. Hyper-V card creation. Narrator now says the name of the VM.

References and relevant issues

https://task.ms/50453529
https://task.ms/50453302
https://task.ms/50453587

Detailed description of the pull request / Additional comments

Validation steps performed

Manually ran through the items.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@dhoehna dhoehna requested review from krschau, sshilov7, bbonaby and a team May 22, 2024 18:16
Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include a comment about how setting the accessible name in the resw file didn't work because DataTemplate?

@dhoehna
Copy link
Contributor Author

dhoehna commented May 23, 2024

Maybe include a comment about how setting the accessible name in the resw file didn't work because DataTemplate?

Added.

@dhoehna dhoehna merged commit eac4432 into main May 23, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants