Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Fix environment card text colors for high contrast users #3808

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix environment card text colors for high contrast users #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/Environments/Styles/HorizontalCardStyles.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
x:Key="CardBodyStateTextBlockStyle"
BasedOn="{StaticResource CaptionTextBlockStyle}"
TargetType="TextBlock">
<Setter Property="Foreground" Value="{ThemeResource TextFillColorTertiaryBrush}" />
<Setter Property="Foreground" Value="{ThemeResource TextFillColorPrimaryBrush}" />
<Setter Property="TextTrimming" Value="CharacterEllipsis" />
</Style>

Expand Down
4 changes: 2 additions & 2 deletions tools/SetupFlow/DevHome.SetupFlow/Views/SetupTargetView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@
VerticalAlignment="Center">
<TextBlock
Text="{x:Bind DisplayName, Mode=OneWay}"
Foreground="{ThemeResource TextFillColorSecondaryBrush}"
Foreground="{ThemeResource TextFillColorPrimaryBrush}"
Margin=" 0 0 0 0"
Copy link
Contributor Author

@bbonaby bbonaby Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was originally a secondary color but I'm changing it to be primary like the textblock below it. They both should have been the same color.

This line represents the "Microsoft Dev Box" text in the image below:

image

IsTextSelectionEnabled="True"/>
<TextBlock
Margin="7 0 0 0"
Text="{x:Bind FormattedDeveloperId, Mode=OneWay}"
Foreground="{ThemeResource TextFillColorTertiaryBrush}"
Foreground="{ThemeResource TextFillColorPrimaryBrush}"
Style="{ThemeResource BodyTextBlockStyle}"
IsTextSelectionEnabled="True"/>
</StackPanel>
Expand Down
Loading