-
Notifications
You must be signed in to change notification settings - Fork 258
feature/smoke tests #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/smoke tests #2337
Conversation
dae78e6
to
9f65643
Compare
@baywet let me share a proposal for this PR 🙂 Would it be possible to split it into multiple PRs? I would really like to properly review the infrastructure work, but it's getting a bit "noisy". |
@andreaTP Thanks for the suggestion. I'm going to implement most languages myself as part of this PR (this is core work for the GA, I don't think it'd be fair to "delegate" it to the community). The work is still early, I'm exploring things at this point and each test requires a commit to be pushed (as opposed to running things locally). I'm still expecting large changes and splitting things up at this stage would introduce a lot of coordination overhead. As for the noise, you can ignore the PR as long as it's in draft, and only pay attention to it when it switches to ready for review. |
cdabe2f
to
5f37727
Compare
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…class property Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
0d76d4f
to
ddf418e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great to bring in and setup.
Just a couple of suggestions. Otherwise, looks good to me.
src/Kiota.Builder/SearchProviders/GitHub/GitHubSearchProvider.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Builder/SearchProviders/APIsGuru/APIsGuruSearchProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eastman <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Haven't had time to review, but the output seems really great! 👍 well bone @baywet !!! |
@baywet checking this a little bit more through, awesome job! The setup looks a bit tricky(as expected ...), do we have any "easy way" to run one of those tests for development purposes? Would a top-level Based on the previous, would running into a pre-configured Docker image(with all of the tools already installed) help in terms of the reproducibility of the setup? |
a mock server would be an awesome step forward! I think that if we want to get there we first need to address a lot of the issues that were discovered. Then we'd need to tweak the projects a bit so they make calls, or even generate the calls to make? As per the docker image, are you thinking of adding all the language dependencies onto a single image definition or about something else? |
Not a fully formed idea unfortunately, I'm only trying to understand how the tests can be easily run during the dev cycle locally (as opposed to "in CI"). |
fixes #2020