fix: handle None sys.stdout.encoding in CLI output#1656
Open
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: handle None sys.stdout.encoding in CLI output#1656octo-patch wants to merge 1 commit intomicrosoft:mainfrom
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1597
Problem
When
sys.stdout.encodingisNone(e.g. when stdout is replaced with araw binary stream, or in certain CI/redirected environments), the current
_handle_outputcode in__main__.pycalls:This raises
TypeError: encode() argument 'encoding' must be str, not Noneinstead of the expected
UnicodeEncodeError, making the CLI crash with anunhelpful error.
Solution
Fall back to
"utf-8"whensys.stdout.encodingisNone:The existing
errors="replace"handling is preserved, so non-UTF-8terminals (e.g. Windows cp1252) still work correctly.
Testing
Manually verified that the existing
errors="replace"path continues towork, and that the
Nonefallback is triggered correctly: