test: refactor trace viewer tests to use actual trace viewer #2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
use-real-trace-viewer
branch
from
1d2c129 to
a8784e0
Compare
mxschmitt
force-pushed
the
use-real-trace-viewer
branch
from
a8784e0 to
4d23f5c
Compare
mxschmitt
commented
Jun 11, 2025
| @@ -57,10 +57,12 @@ def headless(pytestconfig: pytest.Config) -> bool: | |||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def launch_arguments(pytestconfig: pytest.Config, headless: bool) -> Dict: | |||
| return { | |||
| args: Dict = { | |||
There was a problem hiding this comment.
The background of this change is interesting:
- This before returned
channel: None->channel: null - We use this inside
npx playwright launch-server --config config.json - Inside Playwright we don't really accept
nullas a channel option, onlyundefined, we don't validate it tho and send it to the server - Inside the Server we put the channel value into the
context-optionsand then render it in the Trace Viewer. We manually serialise thecontext-optionsbefore here - This treats
nullas an object and it ends up as an empty object. We try to render it in React and'boom'React crashes, since it doesn't allow that.
I'm thinking if this is an edge case in our test or if user-values could also result in such a scenario. I think a null/undefined check makes probably sense there!
dgozman
approved these changes
Jun 11, 2025
| return self.page.get_by_test_id("stack-trace-list").locator(".list-view-entry") | ||
|
|
||
| def select_action(self, title: str, ordinal: int = 0) -> None: | ||
| self.page.locator(f'.action-title:has-text("{title}")').nth(ordinal).click() |
There was a problem hiding this comment.
Let's use something like self.action_titles.filter(has_text=...) instead.
| self.page.locator(f'.action-title:has-text("{title}")').nth(ordinal).click() | ||
|
|
||
| def select_snapshot(self, name: str) -> None: | ||
| self.page.click(f'.snapshot-tab .tabbed-pane-tab-label:has-text("{name}")') |
|
|
||
| @property | ||
| def stack_frames(self) -> Locator: | ||
| return self.page.get_by_test_id("stack-trace-list").locator(".list-view-entry") |
There was a problem hiding this comment.
It would be great to update trace viewer, so this becomes get_by_role("list", name="Stack Trace").get_by_role("listitem").
| return self.page.frame_locator("iframe.snapshot-visible[name=snapshot]") | ||
|
|
||
| def show_source_tab(self) -> None: | ||
| self.page.click("text='Source'") |
There was a problem hiding this comment.
Some kind of get_by_role() would be great here!
| self.page.click("text='Source'") | ||
|
|
||
| def expand_action(self, title: str, ordinal: int = 0) -> None: | ||
| self.actions_tree.locator(".tree-view-entry", has_text=title).nth( |
There was a problem hiding this comment.
Similarly, clicking on a button should have a get_by_role("button").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.