Skip to content

Conversation

@polarG
Copy link
Contributor

@polarG polarG commented Jan 6, 2026

Description

  • When building the CUDA 11.1.1 image, pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1). As a result, pip attempts to build wandb from source. However, the build fails because the image does not have Go installed, which is required for building wandb from source. Then the error appears.
  • Deprecated API arguments, 'interpolation'.

Solution

  • Anchor wandb to 0.22.3 when python version is 3.8.
  • numpy API update for >v1.22.0.

@polarG polarG self-assigned this Jan 6, 2026
@polarG polarG added the enhancement New feature or request label Jan 6, 2026
@polarG polarG requested a review from a team as a code owner January 6, 2026 22:55
@polarG polarG added CI/CD Continuous integration or deployment dependencies Pull requests that update a dependency file labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (c99380b) to head (22fd5f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   85.69%   85.70%           
=======================================
  Files         102      102           
  Lines        7699     7703    +4     
=======================================
+ Hits         6598     6602    +4     
  Misses       1101     1101           
Flag Coverage Δ
cpu-python3.10-unit-test 70.96% <60.00%> (-0.02%) ⬇️
cpu-python3.12-unit-test 70.96% <60.00%> (+0.01%) ⬆️
cpu-python3.7-unit-test 70.43% <100.00%> (+0.01%) ⬆️
cuda-unit-test 83.59% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG changed the title CI/CD - Fix Image build for cuda11.1.1 CI/CD - Fix Image build for cuda11.1.1 and update numpy API Jan 7, 2026
@polarG polarG requested review from abuccts and guoshzhao January 7, 2026 18:33
np.percentile(result, float(percentile), interpolation='nearest'), reduce_type
)
try:
val = np.percentile(result, float(percentile), method='nearest')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need update this? Have you met some failure?

Copy link
Contributor Author

@polarG polarG Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I met it after the changes for wandb. In PR, this is also appeared.

Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)

According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?

However, the build fails because the image does not have Go installed, which is required for building wandb from source.

Why not just add an apt-get install -y golang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Continuous integration or deployment dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants