-
Notifications
You must be signed in to change notification settings - Fork 80
CI/CD - Fix Image build for cuda11.1.1 and update numpy API #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 102 102
Lines 7699 7703 +4
=======================================
+ Hits 6598 6602 +4
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| np.percentile(result, float(percentile), interpolation='nearest'), reduce_type | ||
| ) | ||
| try: | ||
| val = np.percentile(result, float(percentile), method='nearest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need update this? Have you met some failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I met it after the changes for wandb. In PR, this is also appeared.
abuccts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)
According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?
However, the build fails because the image does not have Go installed, which is required for building wandb from source.
Why not just add an apt-get install -y golang?
Description
Solution