Skip to content
This repository was archived by the owner on Oct 2, 2021. It is now read-only.
This repository was archived by the owner on Oct 2, 2021. It is now read-only.

Enable source maps by default to simplify configuration #134

Closed
@auchenberg

Description

@auchenberg
Contributor

Given the popularity of sourcemaps we should flip our default setting, so sourcemap support are enabled by default.

Rational:
If a source map is present it's most likely needed to resolve paths correctly. Some people don't notice the sourcemap config, and end up with a bad first time experience.

We should therefore flip the setting, and explicitly allow people to disable source maps if needed.

This would simplify the default configs too.

Activity

added this to the Backlog milestone on Nov 29, 2016
roblourens

roblourens commented on Dec 5, 2016

@roblourens
Member

Thoughts on this @weinand? It shouldn't break anyone since you can turn on 'sourceMaps' then debug your code without sourcemaps just fine.

weinand

weinand commented on Dec 5, 2016

@weinand

If this change affects node2, then we will have to flip the defaults in node1 as well.
I will investigate what consequences this has in the January milestone.

roblourens

roblourens commented on Dec 5, 2016

@roblourens
Member

Right, it should be consistent across. We can change it in chrome-debug to experiment.

auchenberg

auchenberg commented on Dec 6, 2016

@auchenberg
ContributorAuthor

Let's ship this in the Chrome debugger, and evaluate the results.

roblourens

roblourens commented on Jan 2, 2017

@roblourens
Member

Enabled for chrome-debug in 2.4.2!

auchenberg

auchenberg commented on Jan 3, 2017

@auchenberg
ContributorAuthor

Yay. Let's see how people are gonna react to this.

locked and limited conversation to collaborators on Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @auchenberg@roblourens@weinand

      Issue actions

        Enable source maps by default to simplify configuration · Issue #134 · microsoft/vscode-chrome-debug-core