Fix issues with remapping of .C files
#13476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
.C file to C
sean-mcmanus
previously approved these changes
Apr 9, 2025
Colengms
changed the title
.C files
sean-mcmanus
previously approved these changes
Apr 9, 2025
….com/microsoft/vscode-cpptools into dev/coleng/fix_language_change_issue
sean-mcmanus
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the explicit association of
.Cfiles infiles.associationswas not respected. We will now only remap a.Cfile to C++ if there is not an existing mapping for the file.Because the first attempt to open the file wrote to the
files.associations, subsequent attempts to change the language ID using the UI will now properly take precedence (as long as thefiles.associationsentry exists, regardless of what it's set to).Also fixes a bug in a prior change that could result in visible files not being tracked properly.