Skip to content

Add a message explaining why we couldn't find a quote-wrapped path #13521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Apr 16, 2025

Fixes: #11955

The bug suggests that we shouldn't show an error for paths wrapped in quotes, but we had decided to treat these strings literally since a double quote is a valid path character on some platforms.

Instead, this message improvement should signal to users that they should not place extra quotes around paths.

image

@bobbrow bobbrow requested a review from a team as a code owner April 16, 2025 19:49
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Apr 16, 2025
@sean-mcmanus sean-mcmanus requested a review from Colengms April 16, 2025 19:51
@sean-mcmanus
Copy link
Contributor

Why are the 2 quotes in your screenshot:
image

@bobbrow
Copy link
Member Author

bobbrow commented Apr 16, 2025

Why are the 2 quotes in your screenshot:
image

That's how it's currently implemented. We put quotes around the path for the json squiggle and then the path itself has quotes around it.

@sean-mcmanus
Copy link
Contributor

That's how it's currently implemented. We put quotes around the path for the json squiggle and then the path itself has quotes around it.

But it's inconsistent with the UI message? Is that intentional?

@bobbrow
Copy link
Member Author

bobbrow commented Apr 16, 2025

That's how it's currently implemented. We put quotes around the path for the json squiggle and then the path itself has quotes around it.

But it's inconsistent with the UI message? Is that intentional?

I believe it might have been done that way because we show all the paths on the same line for the tooltip, but in the UI we give each error its own line. It makes the paths easier to differentiate.

image

sean-mcmanus
sean-mcmanus previously approved these changes Apr 16, 2025
@sean-mcmanus sean-mcmanus added this to the 1.25.1 milestone Apr 16, 2025
@sean-mcmanus sean-mcmanus removed the request for review from Colengms April 16, 2025 20:56
@bobbrow bobbrow merged commit 735d741 into main Apr 16, 2025
6 checks passed
@bobbrow bobbrow deleted the bobbrow/pathValidation branch April 16, 2025 21:04
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect configuration JSON/UI warnings appear when quotes are used
2 participants