Fixes #2122 tools are also found at GOBIN path

[marcel-basel]

If go.toolsGopath setting is set, goInstallTools.installTools was already setting GOBIN env to ''. With no go.toolsGopath set but GOBIN defined the tools are installed in GOBIN path already. The log message had to be corrected (Installing x tools at ...).

GOBIN was added to the list of places where the extension looks for the tools

[msftclas]

All CLA requirements met.

[ramya-rao-a]

What is the reason for making a copy of the env variables?
Since we are only reading the env var values, process.env can be directly used.

[ramya-rao-a]

This if check can be removed. If no GOBIN is set, then getBinPathFromEnvVar() will return null anyway.

[ramya-rao-a]

Please rename to pathFromGoBin to match the patterns of pathFromGoRoot and pathFromPath names used later on

[marcel-basel]

Commited the requested changes

[ramya-rao-a]

If GOBIN is set, then we can essentially skip the code path

vscode-go/src/goInstallTools.ts

Lines 124 to 145 in 8660153

	} else {
	toolsGopath = getCurrentGoPath();
	outputChannel.appendLine(`go.toolsGopath setting is not set. Using GOPATH ${toolsGopath}`);
	}
	if (toolsGopath) {
	const paths = toolsGopath.split(path.delimiter);
	toolsGopath = paths[0];
	envForTools['GOPATH'] = toolsGopath;
	} else {
	const msg = 'Cannot install Go tools. Set either go.gopath or go.toolsGopath in settings.';
	vscode.window.showInformationMessage(msg, 'Open User Settings', 'Open Workspace Settings').then((selected) => {
	switch (selected) {
	case 'Open User Settings':
	vscode.commands.executeCommand('workbench.action.openGlobalSettings');
	break;
	case 'Open Workspace Settings':
	vscode.commands.executeCommand('workbench.action.openWorkspaceSettings');
	break;
	}
	});
	return;
	}

right?

[marcel-basel]

We still have to set the current go path envForTools['GOPATH'] = toolsGopath; since envForTools is passed as options when go get child process is created. GOBIN is only setting the path where the executable should be installed. Right?

[ramya-rao-a]

Hmmm fair point

[ramya-rao-a]

Also, there are some linting errors that need to be fixed.

Run npm run lint to find the above errors
Run npm run fix-lint to fix the automatically fixable linting errors