This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Handle unexpected proxy query results gracefully#3205
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Apr 25, 2020
neclepsio:master
Merged
Handle unexpected proxy query results gracefully#3205ramya-rao-a merged 1 commit intomicrosoft:masterfrom neclepsio:master
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
neclepsio:master
Conversation
Contributor
|
Thanks for the fix! The linked issue in the title has the full description already, but it's always nice to have a descriptive commit message - unless @ramya-rao-a will manually edit the commit message before merge. |
hyangah
approved these changes
Apr 24, 2020
ramya-rao-a
approved these changes
Apr 25, 2020
Contributor
ramya-rao-a
left a comment
There was a problem hiding this comment.
Looks like this is your first PR contribution to this project @neclepsio
Thanks & Welcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the proxy contacted for the released gopls version list does not
respond following the Go module proxy protocol but return unexpected
contents (e.g. login page) semver parsing will fail, trigger an exception,
and cause the language server client not to start.
Fixes #3204