Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Fixes #299 Run without debug#881

Merged
ramya-rao-a merged 3 commits intomicrosoft:masterfrom
ramya-rao-a:nodebug
Mar 22, 2017
Merged

Fixes #299 Run without debug#881
ramya-rao-a merged 3 commits intomicrosoft:masterfrom
ramya-rao-a:nodebug

Conversation

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a commented Mar 22, 2017

Supported only when mode = debug and program points to a file

@ramya-rao-a
Copy link
Copy Markdown
Contributor Author

@roblourens Once the program has completed running, the debug mode is not exited. Need to click the stop button manually. Anything I am missing?

@roblourens
Copy link
Copy Markdown
Member

You need to send a TerminatedEvent when 'go run' closes. Normally it looks like we send this when delve tells us that the process has exited.

@roblourens
Copy link
Copy Markdown
Member

Otherwise, looks good

@ramya-rao-a ramya-rao-a merged commit 29a5a49 into microsoft:master Mar 22, 2017
@ramya-rao-a ramya-rao-a deleted the nodebug branch April 9, 2017 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants