Feedback on Single Panel Detail Panel

[jo-oikawa]

Bugs:

1. Two 'add tab' buttons are appearing at the same time
2. Screen cheese on the diff sections between the scrollbar, checkmark icon, and file title

UI/Polish

• Dropdown menu subheader text color isn't accessible in selected state (Jo to provide alternative, this is a larger bug)
• New tab button doesn't need background-fill on resting state
• Tab titles do not need bold font weight
• File diff summary '[icon] X files +AA -BB' should not be bold font weight either
  • Do we need the diff icon in front of this too?
• Missing padding beneath the changes-specific header row (suggestion: increase to 4px so buttons aren't 'touching' content below)
• -Feedback from Rob: suggested improving space efficiency, supporting inline diffs, and questioned the wide margins with line numbers in the multi-diff editor.

Missing padding:

Design for suggested font weights:

UX/Behavior:

• We should have a better empty state for the 'Search' tab, letting users know they can search settings, files, etc.
• Browser doesn't need the 'List' toggle icon
• Related, should the 'maximize' action to be right next to the meatball menu since that will be more consistently present? (ex. the browser might not need this option)
• Feedback from Ben S: unified views and file tab bar to be unintuitive, preferring the editor grid within the "files" tab and feeling that actions belonging to a file were disconnected from the open editor
• Feedback from Rob: a way to expand all collapsed sections to read files more easily, want the option to toggle between inline and side-by-side diffs, similar to normal diff editors