Support path links that contain spaces in the integrated terminal

[nielsvaneck]

• VSCode Version: 1.45.1
• OS Version: MacOS 10.15.4

Steps to Reproduce:

1. create a vscode python project in a directory with a space that contains some code that produces a failing test or stacktrace
2. hover over the paths in the stacktrace and notice that those with a space in a directory name are not rendered as links. those without spaces are.

I have created a tiny repo that reproduces the bug: https://github.com/nielsvaneck/vscode_space_path_bug

Does this issue occur when all extensions are disabled?: Yes

[Tyriar]

For the case that you linked I don't think it's expected that it would be linkified on Linux and macOS when the \ before the space is not present, what tools are outputting this? (it's a little more nuanced on Windows)

[nielsvaneck]

For the case that you linked I don't think it's expected that it would be linkified on Linux and macOS when the \ before the space is not present, what tools are outputting this? (it's a little more nuanced on Windows)

just the error output generated by the python interpreter

[smcoll]

Am i having the same issue, or is this different?

In the terminal, paths in the Python traceback are not linked/clickable if there is a space in the path, even though the path is quoted. For example:

File "/home/me/some space/myproject/mypapp/models.py", line 360, in foo
    for obj in qs.distinct()

That seems to be the issue referenced by microsoft/vscode-python#7491 (closed and conversation locked) which was moved to #81190 (closed and conversation locked) which is marked as a duplicate of #21125 which is supposedly fixed (closed and conversation locked).

Same problem for traceback inlined in the code editor while debugging (i'm not sure what this UI component is called, or where to find out).

[Tyriar]

@smcoll this is the same issue yes.

As of 1.49.0 we have stabilized the link provider API which would allow Python to add better support to Python-specific link formats like this one. The problem we face is the output could be literally everything, so our list of detection continues to grow and get slower and slower. While we could provide better support for spaces in names (that's what this issue is about), Python could improve the support by making this link do something with foo if that's useful

File "/home/me/some space/myproject/mypapp/models.py", line 360, in foo

And maybe even give this line a link to do something useful:

for obj in qs.distinct()

FYI @luabud

[smcoll]

@Tyriar is the line considered Python-specific because it's a format used in Python tracebacks? And are you saying that Python support could choose to link right to that line in the file, for example?

i opened microsoft/vscode-python#7491 hoping that the original issue for the Python extension can be re-opened.