Skip to content

defaults web issue report false and disable in Firefox #213752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justschen merged 2 commits into from
May 29, 2024
Merged

defaults web issue report false and disable in Firefox #213752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad230ee
turn off in release and in ff
justschen May 29, 2024
a017192
update
justschen May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/issue/browser/issue.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
properties: {
'issueReporter.experimental.webReporter': {
type: 'boolean',
default: true,
default: false,
description: 'Enable experimental issue reporter for web.',
},
}
Expand Down
5 changes: 3 additions & 2 deletions src/vs/workbench/contrib/issue/browser/issueService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import * as dom from 'vs/base/browser/dom';
import { userAgent } from 'vs/base/common/platform';
import { isFirefox, userAgent } from 'vs/base/common/platform';
import { IExtensionDescription, ExtensionType } from 'vs/platform/extensions/common/extensions';
import { normalizeGitHubUrl } from 'vs/platform/issue/common/issueReporterUtil';
import { getZoomLevel } from 'vs/base/browser/browser';
Expand Down Expand Up @@ -49,7 +49,8 @@ export class BrowserIssueService implements IWorkbenchIssueService {
}

async openReporter(options: Partial<IssueReporterData>): Promise<void> {
if (!this.configurationService.getValue<boolean>('issueReporter.experimental.webReporter')) {
// If web reporter setting is false, or if we are in Firefox, open the old GitHub issue reporter
if (!this.configurationService.getValue<boolean>('issueReporter.experimental.webReporter') || isFirefox) {
const extensionId = options.extensionId;
// If we don't have a extensionId, treat this as a Core issue
if (!extensionId) {
Expand Down