Exclude electron/get's ELECTRON_GET_USE_PROXY variable from exclusion#324749
Open
1D17B65E wants to merge 1 commit into
Open
Exclude electron/get's ELECTRON_GET_USE_PROXY variable from exclusion#3247491D17B65E wants to merge 1 commit into
electron/get's ELECTRON_GET_USE_PROXY variable from exclusion#3247491D17B65E wants to merge 1 commit into
Conversation
`ELECTRON_GET_USE_PROXY` is used in the Electron download performed by [electron/get](https://github.com/electron/get) to enable proxy rerouting. It's very confusing that the download doesn't work when the download is run from an integrated terminal session. Since the variable doesn't have an effect on running Electron instances (especially the one hosting VS Code itself), it's safe to exclude it from the exclusion.
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #324748 by allowing the ELECTRON_GET_USE_PROXY environment variable to pass through VS Code's process environment sanitization. This variable is used by electron/get to enable proxy rerouting during Electron downloads; previously it was stripped in integrated terminal sessions (since it matched the ELECTRON_* removal pattern), causing confusing download failures. Because the variable has no effect on running Electron instances, it is safe to preserve.
Changes:
- Updated the
ELECTRON_*removal regex insanitizeProcessEnvironmentto use a negative lookahead that excludesELECTRON_GET_USE_PROXY. - Extended the unit test to cover the newly preserved variable and updated the expected key count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/base/common/processes.ts |
Adds a negative lookahead to the ELECTRON_* removal pattern so ELECTRON_GET_USE_PROXY is retained during environment sanitization. |
src/vs/base/test/common/processes.test.ts |
Adds ELECTRON_GET_USE_PROXY to the test env, asserts it is preserved, and updates the expected remaining-key count from 3 to 4. |
electron/gets ELECTRON_GET_USE_PROXY variable from exclusionelectron/get's ELECTRON_GET_USE_PROXY variable from exclusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELECTRON_GET_USE_PROXYis used in the Electron download performed by electron/get to enable proxy rerouting. It's very confusing that the download doesn't work when the download is run from an integrated terminal session. Since the variable doesn't have an effect on running Electron instances (especially the one hosting VS Code itself), it's safe to exclude it from the exclusion.Resolves #324748.