Skip to content

Exclude electron/get's ELECTRON_GET_USE_PROXY variable from exclusion#324749

Open
1D17B65E wants to merge 1 commit into
microsoft:mainfrom
1D17B65E:exclude-electron-get-variable
Open

Exclude electron/get's ELECTRON_GET_USE_PROXY variable from exclusion#324749
1D17B65E wants to merge 1 commit into
microsoft:mainfrom
1D17B65E:exclude-electron-get-variable

Conversation

@1D17B65E

@1D17B65E 1D17B65E commented Jul 7, 2026

Copy link
Copy Markdown

ELECTRON_GET_USE_PROXY is used in the Electron download performed by electron/get to enable proxy rerouting. It's very confusing that the download doesn't work when the download is run from an integrated terminal session. Since the variable doesn't have an effect on running Electron instances (especially the one hosting VS Code itself), it's safe to exclude it from the exclusion.

Resolves #324748.

`ELECTRON_GET_USE_PROXY` is used in the Electron download performed by [electron/get](https://github.com/electron/get) to enable proxy rerouting. It's very confusing that the download doesn't work when the download is run from an integrated terminal session. Since the variable doesn't have an effect on running Electron instances (especially the one hosting VS Code itself), it's safe to exclude it from the exclusion.
Copilot AI review requested due to automatic review settings July 7, 2026 12:56
@1D17B65E

1D17B65E commented Jul 7, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #324748 by allowing the ELECTRON_GET_USE_PROXY environment variable to pass through VS Code's process environment sanitization. This variable is used by electron/get to enable proxy rerouting during Electron downloads; previously it was stripped in integrated terminal sessions (since it matched the ELECTRON_* removal pattern), causing confusing download failures. Because the variable has no effect on running Electron instances, it is safe to preserve.

Changes:

  • Updated the ELECTRON_* removal regex in sanitizeProcessEnvironment to use a negative lookahead that excludes ELECTRON_GET_USE_PROXY.
  • Extended the unit test to cover the newly preserved variable and updated the expected key count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/base/common/processes.ts Adds a negative lookahead to the ELECTRON_* removal pattern so ELECTRON_GET_USE_PROXY is retained during environment sanitization.
src/vs/base/test/common/processes.test.ts Adds ELECTRON_GET_USE_PROXY to the test env, asserts it is preserved, and updates the expected remaining-key count from 3 to 4.

@1D17B65E 1D17B65E changed the title Exclude electron/gets ELECTRON_GET_USE_PROXY variable from exclusion Exclude electron/get's ELECTRON_GET_USE_PROXY variable from exclusion Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ELECTRON_GET_USE_PROXY excluded from integrated terminal environments

3 participants