Editor - resource label should use test-overflow#324819
Open
lszomoru wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI bug (issue #324597) in the multi-diff editor header where the file-change status indicator overlapped the file name. It corrects the resource-label overflow handling and hides the status marker when there is no meaningful change flag to display.
Changes:
- Moved
min-width: 0andtext-overflow: ellipsisfrom.title.originalto the shared.titleselector and addedoverflow: hidden, enabling proper ellipsis truncation for both the primary and secondary paths. - Added a rule to hide the
.statuselement when it has noadded/deleted/renamedclass, removing the empty marker (and its horizontal margin) that overlapped the file name.
Show a summary per file
| File | Description |
|---|---|
| src/vs/editor/browser/widget/multiDiffEditor/style.css | Consolidates overflow/ellipsis styling on .title and hides the empty status marker to prevent it overlapping the file name. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
benvillalobos
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324597