Add chat terminal sandbox smoke tests#324848
Draft
dileepyavan wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Electron smoke-test suite to exercise the Chat terminal sandbox (chat.agent.sandbox.enabled) on Linux/macOS using deterministic mock-LLM tool calls plus a local HTTP probe, and wires the suite into the desktop (non-remote) smoke run.
Changes:
- Register a new “Chat Sandbox” smoke-test suite in the main Electron smoke runner.
- Add end-to-end sandbox validations for: terminal execution, workspace vs outside-workspace write behavior, outside-workspace reads, TMPDIR writes, and default network denial.
- Use a mock LLM server +
echo-last-messagetool-result echoing to assert against the tool output payload.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/main.ts | Registers the new Chat Sandbox smoke suite for Electron non-remote runs. |
| test/smoke/src/areas/chat/chatSandbox.test.ts | New Linux/macOS smoke suite that drives chat tool calls to validate terminal sandbox filesystem + network restrictions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat.agent.sandbox.enabledValidation
cd test/smoke && npm run compilenpm run precommitThe end-to-end suite has not completed successfully in the current local environment because Chat did not become ready during the smoke-test warm-up, so this is opened as a draft for CI validation and iteration.