Add a receive buffer for messages#155
Open
dannytrigo wants to merge 1 commit into
Open
Conversation
messages that are not fully available in one recv call
dannytrigo
force-pushed
the
receive_buffer_upstream
branch
from
4971bda to
8ae6068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, I was really struggling to receive
dock.receiver-information=queryresponses using the async Receiver, because it runs with 0 timeout on the get calls. It would fail part way through a message, then the next attempt to get would throw an assertion failure because it was reading midway through that message and not finding the magic bytes.This change adds a buffer where the data is held and only released once full eISCP packets are ready.