Massive rewrite of excel importer, added many other control realms, and updated 12+ versions to v1.48 (from 1.34)#160
Open
mitchcapper wants to merge 9 commits into
Conversation
Fixed many prior encoding and naming issues
mitchcapper
added a commit
to mitchcapper/onkyo-eiscp-dotnet
that referenced
this pull request
Mar 12, 2025
…nd, and tools to get your receiver specific groups (along with now exposing what options support what groups). Version updates per main repo. miracle2k/onkyo-eiscp#160
Author
|
This has been integrated into my .net updates along with additional helpers there: miracle2k/onkyo-eiscp-dotnet#1 |
fixed split commands generation
mitchcapper
changed the title
strip ether also from model names, 15% fewer model groups
Thank you
mitchcapper
force-pushed
the
importer_rewrite_proto_upgrade
branch
from
2f61776 to
b92e955
Compare
Author
|
Thanks @vslavik I am happy to report this PR just advanced 4 more years to the protocol as of 2025-02-03. |
mitchcapper
force-pushed
the
importer_rewrite_proto_upgrade
branch
from
6dc6593 to
e76e72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo is likely dead but it seems most fitting to put here. The biggest change here is the massive rewrite to import_protocol_doc.py. Previously either the excel file or the output were hand edited/changed to make things work. This was a rewrite of most of the logic to make it all automated, standardize some naming, and fix decoding and other issues in the older parser. This massively increased the export by handling all the different control environments too allowing for IR/CEC/ etc control without manually doing so.
It imports the v148 file directly without requiring any changes. This code was AI assisted for the generation and iteration to get the formatting and naming as close to prior as possible and detect various patterns.
The last full generation was v1.34 (Jan of 2016) this brings it to v1.48 (April 2021).
If anyone can find a newer one let me know:)