Add chat templates integration #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliendenize
commented
Dec 1, 2025
juliendenize
force-pushed
the
chat_templates
branch
from
4ee85dc to
ddb0a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add chat templates inside this repo as a valid working implementation in comparison with mistral-common to work with libraries that require jinja templates (llama.cpp, vanilla Transformers, SG Lang ...).
This is in order to give the possibility to our community to use our models beyond the scope of mistral-common when the latter is not integrated in parts of the ecosystem.
We validate these chat templates on a set of dummy requests.
Next step is to add tests for edge cases and errors + integration tests on some datasets.