Skip to content

1.12.3 Changelog#27611

Merged
vieux merged 1 commit intomoby:1.12.xfrom
vieux:changelog-1.12.3
Oct 24, 2016
Merged

1.12.3 Changelog#27611
vieux merged 1 commit intomoby:1.12.xfrom
vieux:changelog-1.12.3

Conversation

@vieux
Copy link
Copy Markdown
Contributor

@vieux vieux commented Oct 20, 2016

ping @thaJeztah

@vieux vieux added this to the 1.12.3 milestone Oct 20, 2016
@vieux vieux self-assigned this Oct 20, 2016
thaJeztah
thaJeztah reviewed Oct 21, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits / suggestions, but LGTM otherwise

CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably describe what it's fixing as well; Also should this be in the "Builder" section?

* Fix an error when trying to `ADD` or `COPY` files to the root  (`/`) of the container's filesystem

@tonistiigi SGTY? ^^

Copy link
Copy Markdown
Member

@tonistiigi tonistiigi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is in file extraction so not directly related to builder. Could probably happen in pull/load/cp as well in certain conditions. I'd add "during extraction ...". Or "Properly handle shared mount propagation in storage directory".

Copy link
Copy Markdown
Contributor Author

@vieux vieux Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Properly handle shared mount propagation in storage directory

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing https://github.com/ here and couple below

@vieux vieux force-pushed the changelog-1.12.3 branch 3 times, most recently from 9a35aa3 to a4f62a0 Compare October 21, 2016 21:17
@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Oct 21, 2016

please take a look @aaronlehmann @mrjana @riyazdf

mrjana
mrjana reviewed Oct 21, 2016
View reviewed changes
CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@mrjana mrjana Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following as well:

icecrime
icecrime suggested changes Oct 21, 2016
View reviewed changes
CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@icecrime icecrime Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Update" instead of "Vendor"?

Copy link
Copy Markdown
Contributor Author

@vieux vieux Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icecrime we used vendor previously in 1.12.2 already but I can change

CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@icecrime icecrime Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if that's intentional, but this isn't a properly formatted markdown link.

Copy link
Copy Markdown
Contributor Author

@vieux vieux Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

riyazdf
riyazdf suggested changes Oct 21, 2016
View reviewed changes
CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@riyazdf riyazdf Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Fix user permissions in containers/Fix ambient capability usage in containers/

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CVE-2016-8867 not published yet?

http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-8867

Copy link
Copy Markdown
Contributor

@riyazdf riyazdf Oct 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not published yet, but we've received a confirmed ID from MITRE.

We will keep everyone posted as we get details back from MITRE, but that pull request and the linked issue describe the ambient capability misconfiguration.

@vieux vieux force-pushed the changelog-1.12.3 branch 2 times, most recently from 4308575 to a31a9bb Compare October 21, 2016 23:53
@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Oct 21, 2016

@icecrime @riyazdf PTAL

@vieux
1.12.3 Changelog
548f8f0 
Signed-off-by: Victor Vieux <vieux@docker.com>
@icecrime
Copy link
Copy Markdown
Contributor

icecrime commented Oct 22, 2016

LGTM

icecrime
icecrime approved these changes Oct 22, 2016
View reviewed changes
CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@icecrime icecrime Oct 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: missing new line.

Copy link
Copy Markdown
Contributor Author

@vieux vieux Oct 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

riyazdf
riyazdf approved these changes Oct 22, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vieux vieux merged commit c5ac1fc into moby:1.12.x Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi left review comments

@thaJeztah thaJeztah thaJeztah left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

+3 more reviewers

@mrjana mrjana mrjana left review comments

@icecrime icecrime icecrime approved these changes

@riyazdf riyazdf riyazdf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vieux vieux

Labels

status/3-docs-review

Projects

None yet

Milestone

1.12.3

Development

Successfully merging this pull request may close these issues.

8 participants

@vieux @icecrime @tonistiigi @mrjana @thaJeztah @riyazdf @AkihiroSuda @GordonTheTurtle