Update vendored packages, containerd, docker

[thaJeztah]

This updates a big part of the vendored packages to match what's used in https://github.com/moby/moby (I kept out some, such as Cobra, and some helper packages). This makes sure that this repository is developing and testing using the same(ish) version of those packages.

Last four commits update containerd (first to 1.0.2, then to 3fa104f843ec92328912e042b767d26825f202aa); did an attempt to fix up local changes needed for changes in there; it builds with those changes, but quite possibly may need more changes

Named this "WIP", as I'm sure I screwed up somewhere 😂

Updated packages

• github.com/boltdb/bolt: boltdb/bolt@e72f08d...fff57c1
  • no code changes, only changes in documentation
• github.com/containerd/fifo: containerd/fifo@69b9952...fbfb6a1
  • Prevent a data race when Close is called concurrently containerd/fifo#13 Prevent a data race when Close is called concurrently
• golang.org/x/sync: golang/sync@450f422...fd80eb9
  • no code changes, only changes in documentation
• github.com/containerd/containerd containerd/containerd@29a4dd7...3fa104f
• github.com/opencontainers/runc opencontainers/runc@d40db12...4fc53a8
• containerd/continuity containerd/continuity@cf279e6...d8fb858
• golang.org/x/sys golang/sys@7397344...37707fd
• github.com/sirupsen/logrus sirupsen/logrus@v1.0.1...v1.0.3
• golang.org/x/crypto golang/crypto@3fbbcd2...558b687
  • on moby CI, this fixed an issue that was blocking a test from running on ppc64le.
• github.com/Microsoft/go-winio microsoft/go-winio@v0.4.2...v0.4.6
  • LCOW: Dynamic sandbox management moby#34170 LCOW: Dynamic sandbox management
  • pipe: Resolve race between close and connect microsoft/go-winio#70 / Unexpected Docker Daemon shutdown due to ServeAPI error "The pipe is being closed" when docker stats was used moby#34207 pipe: Resolve race between close and connect
• github.com/docker/go-connections docker/go-connections@3ede32e...7beb39f
  • Allow the config API consumer to modify the serv/client default configs
  • Support parsing SCTP port mapping
• github.com/docker/go-units docker/go-units@954fed0...9e638d3
  • Refactor implementation of ParseUlimit function docker/go-units#6 Refactor implementation of ParseUlimit function
  • Enhance FromHumanSize to parse float64 string docker/go-units#8 Enhance FromHumanSize to parse float64 string
  • Unify license docker/go-units#11 Unify license: Use one license for documentation and code
  • make 1 second not to be plural seconds docker/go-units#18 make 1 second not to be plural seconds
  • change week display rule docker/go-units#21 change week display rule
  • Better human duration precision docker/go-units#22 Better human duration precision
  • Removes spaces before unit. docker/go-units#23 Removes spaces before unit to be closer to common Linux outputs.
• github.com/coreos/go-systemd coreos/go-systemd@v12...v15
  • no local changes
• github.com/davecgh/go-spew davecgh/go-spew@5215b55...346938d
  • Adds new config options (DisablePointerAddresses, DisableCapacities)
• github.com/google/certificate-transparency google/certificate-transparency@0f6e3d1...d90e65c
• github.com/docker/libkv docker/libkv@9fd5660...1d84310
  • Add support for etcd authentication docker/libkv#121 Add support for etcd authentication
• github.com/docker/distribution distribution/distribution@b38e583...edc3ab2
  • reference: allow more than 1 digest algorithm separator distribution/distribution#2253 reference: allow more than 1 digest algorithm separator
• github.com/docker/libnetwork moby/libnetwork@2154459...1b91bc9
• github.com/opencontainers/image-spec opencontainers/image-spec@v1.0.0...v1.0.1
  • no code changes
• github.com/opencontainers/runtime-spec opencontainers/runtime-spec@v1.0.0...v1.0.1
  • no code changes
• github.com/docker/docker moby/moby@8af4db6...3d14173
• github.com/containerd/containerd containerd/containerd@29a4dd7...3fa104f

New dependencies

• github.com/ishidawataru/sctp
• github.com/containerd/typeurl

Already ahead

• github.com/coreos/pkg coreos/pkg@fa29b1d...v3
  • not updated, already ahead
• opencontainers/go-digest opencontainers/go-digest@a6d0ee4...21dfd56
  • already ahead

[thaJeztah]

time="2018-03-15T21:54:38Z" level=info msg="22565b52988a5be2 is starting a new election at term 4" module=raft testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="22565b52988a5be2 became candidate at term 5" module=raft testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="22565b52988a5be2 received MsgVoteResp from 22565b52988a5be2 at term 5" module=raft testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="22565b52988a5be2 became leader at term 5" module=raft testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="raft.node: 22565b52988a5be2 elected leader 22565b52988a5be2 at term 5" module=raft testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="error creating cluster object" error="name conflicts with an existing object" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="failed to create predefined network bridge" error="name conflicts with an existing object" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="failed to create predefined network host" error="name conflicts with an existing object" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="Updating the encryption on the root key material of cluster 6ruorplb8zek8su588d6xguvx" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="Stopping manager" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="dispatcher starting" module=dispatcher testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="leadership changed from not yet part of a raft cluster to ch6scvl6j7l7q7mvv1e9gvqme" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="dispatcher stopping" method="(*Dispatcher).Stop" module=dispatcher testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="failed committing allocation of ingress network during init" error="context canceled" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="wait context cancelled" error="context canceled"
time="2018-03-15T21:54:38Z" level=error msg="wait context cancelled but node is still a leader"
time="2018-03-15T21:54:38Z" level=error msg="failed committing allocation of networks during init" error="raft: failed to process the request: node lost leader status" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=error msg="wait cancelled"
time="2018-03-15T21:54:38Z" level=error msg="wait cancelled but node is still a leader"
time="2018-03-15T21:54:38Z" level=error msg="Failed to commit allocation of network resources for nodes" error="raft: failed to process the request: node lost leader status" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
time="2018-03-15T21:54:38Z" level=info msg="Manager shut down" testHasExternalCA=false testname=TestManagerEncryptsDecryptsRootKeyMaterial
FAIL

Don't know if this is just due to flakiness or something else

[thaJeztah]

/cc @ijc @vdemeester @stevvooe

[vdemeester]

LGTM 🐯

[thaJeztah]

Let me remove "WIP", as it seems to be going 😄

Be sure to double check a4fcc8e and 33431b4 (for the local changes)

/cc @dnephin who I think is most familiar with that refactor 😅

[codecov]

Codecov Report

Merging #2560 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   61.35%   61.33%   -0.02%     
==========================================
  Files         133      133              
  Lines       21765    21765              
==========================================
- Hits        13354    13350       -4     
- Misses       6974     6983       +9     
+ Partials     1437     1432       -5

[ijc]

LGTM

[cyli]

Thanks for updating this @thaJeztah - looks like the github.com/docker/docker/pkg/plugingetter.CompatPlugin interface had a ScopedPath method added to it, which breaks one of the tests currently. Perhaps an empty method could be added to the mock plugin getter in that test file?

# github.com/docker/swarmkit/manager/dispatcher
manager/dispatcher/dispatcher_test.go:2065:11: cannot use NewMockPlugin(m.name, client) (type *MockPlugin) as type plugingetter.CompatPlugin in assignment:
	*MockPlugin does not implement plugingetter.CompatPlugin (missing ScopedPath method)
FAIL	github.com/docker/swarmkit/manager/dispatcher [build failed]

[thaJeztah]

@cyli oh, thanks! I knew I'd break something, and must've missed that in the CI output 🤗 I'll try to updated asap.

[thaJeztah]

Added here 👍

[thaJeztah]

Updated 🎉 fingers crossed

[cyli]

LGTM - thanks for updating these and including the links to all the changes! I mostly looked at the certificate transparency and golang/x/crypto changes.

[cyli]

As a note we may have to bump the certificate transparency package for go 1.10: #2563, but that doesn't need to happen in this PR. Just wanted to mention it in case it's useful elsewhere as well.

[thaJeztah]

Ah, yes, I saw that issue as well on my machine. This PR’s intent was to have the dependencies in sync, but I was considering having a look at dependencies in general, to update them across the board (some haven’t been updated for a while, so worth checking if we’re missing out on fixes)