chore: use beta-9.1 instead of beta.10#5821
Conversation
beta-10.0 instead of trying beta.10beta-10.0 instead of beta.10
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5821 +/- ##
==========================================
- Coverage 89.70% 89.66% -0.04%
==========================================
Files 64 64
Lines 4691 4695 +4
Branches 976 976
==========================================
+ Hits 4208 4210 +2
- Misses 483 485 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull request was converted to draft
|
I just realized we'll need to change |
Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com> Agent-Logs-Url: https://github.com/mochajs/mocha/sessions/048dbfb5-1ff4-4bf6-8158-27aff1bae403
|
Done in commit a4ecc77. Updated You'll also need to manually push a tag pointing git tag v12.0.0-beta-9.1 v12.0.0-beta-10
git push origin v12.0.0-beta-9.1 |
beta-10.0 instead of beta.10beta-9.1 instead of beta.10
|
Ref Release Please run 284 which should actually work maybe |
|
Ready for review :) |
PR Checklist
status: accepting prsOverview
Core issue:
beta-9is reported as greater thanbeta-10in semver string comparison, because-is not a proper semver separator. This meansbeta-10is never "latest" whenbeta-9exists.To workaround this, settling on
beta-9.1,beta-9.2, etc. for the remainder of the v12 betas . Then we will go torc.1andrc.2. Mocha 13 will use a normalbeta.1,beta.2approach, but Mocha 12 will suffer from our mistakes :DRef backing issue and #5821 as proof :)
This PR also adds some QoL to Release Please workflows for future diagnoses.
To get this PR to work, I manually pushed a new tag:
Release Please reads git tag data, not just previous release commit data.